jcgruenhage/peshming
1
0
Fork 0
Code Issues 2 Pull requests 1 Packages Releases Wiki Activity

Implement DNS support #6

Open
jcgruenhage wants to merge 1 commit from dns into main
pull from: dns
merge into: jcgruenhage:main
Conversation 0 Commits 1 Files changed 6 +315 -27
jcgruenhage commented 2022-07-26 22:09:04 +00:00
Owner
Copy link

Resolves #4

Resolves #4
jcgruenhage added 1 commit 2022-07-26 22:09:05 +00:00
jcgruenhage reviewed 2022-08-20 14:58:07 +00:00
jcgruenhage left a comment
Author
Owner
Copy link

We need to evaluate whether we want to extend this to allow for proper config reloading in other cases as well, and we need to evaluate whether we want to accept a breaking change in here for the config file format

We need to evaluate whether we want to extend this to allow for proper config reloading in other cases as well, and we need to evaluate whether we want to accept a breaking change in here for the config file format
config.toml.sample
@ -17,0 +16,4 @@
"198.51.100.17" = 500
"203.0.113.55" = 500
"2001:DB8::C0:FF:EE" = 500
"example.org" = 500
jcgruenhage commented 2022-08-10 09:09:48 +00:00
Author
Owner
Copy link

Switched over to proper example documentation IPs instead of putting cloudflare in here.

Switched over to proper example documentation IPs instead of putting cloudflare in here.
src/config.rs
@ -54,0 +54,4 @@
}
#[derive(Deserialize, Clone, Hash, Eq, PartialEq, Debug)]
#[serde(untagged)]
jcgruenhage commented 2022-08-10 09:10:50 +00:00
Author
Owner
Copy link

untagged to avoid breaking changes and to make the config file a bit nicer, but maybe it's worth considering explicitly having a breaking change here and switching to yaml for the config file.

untagged to avoid breaking changes and to make the config file a bit nicer, but maybe it's worth considering explicitly having a breaking change here and switching to `yaml` for the config file.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dns:dns
git checkout dns

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff dns
git checkout main
git merge --ff-only dns
git checkout dns
git rebase main
git checkout main
git merge --no-ff dns
git checkout main
git merge --squash dns
git checkout main
git merge --ff-only dns
git checkout main
git merge dns
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jcgruenhage/peshming#6
No description provided.
Delete branch "dns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?