Add review for yggdrasil-keys v0.2.1
This commit is contained in:
parent
bc36aab4ca
commit
6d6e9be79f
|
@ -0,0 +1,29 @@
|
||||||
|
----- BEGIN CREV PROOF -----
|
||||||
|
kind: package review
|
||||||
|
version: -1
|
||||||
|
date: "2021-01-30T23:12:08.843720526+01:00"
|
||||||
|
from:
|
||||||
|
id-type: crev
|
||||||
|
id: YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM
|
||||||
|
url: "https://git.jcg.re/jcgruenhage/crev-proofs.git"
|
||||||
|
package:
|
||||||
|
source: "https://crates.io"
|
||||||
|
name: yggdrasil-keys
|
||||||
|
version: 0.2.1
|
||||||
|
revision: dae6e3d7188ec5480d65dc1918a358a67e6da89d
|
||||||
|
digest: m78ggbdzQ6XiZ3eKPLbycKjOApscuR8gxpC15jVIi7k
|
||||||
|
review:
|
||||||
|
thoroughness: high
|
||||||
|
understanding: high
|
||||||
|
rating: positive
|
||||||
|
comment: |-
|
||||||
|
I've authored this and we've used it in production. We've had one overflow
|
||||||
|
bug for a while, but we've not experienced any issues after fixing that one.
|
||||||
|
|
||||||
|
We had multiple people look over it by now, and we've not found any more
|
||||||
|
issues. The keys generated by this work fine with yggdrasil-go, and after
|
||||||
|
fixing that one bug we've not experienced any incompatibilites anymore.
|
||||||
|
----- SIGN CREV PROOF -----
|
||||||
|
EIEqdSaScpp4UwO7LCg3EBn5y1PQfJAbzQ63KZOUnei8O5bOkSluMvh1YAqN4o2PmNZbYRX3N3s467fLzPAjCA
|
||||||
|
----- END CREV PROOF -----
|
||||||
|
|
Loading…
Reference in a new issue