playmusicexporter/playmusicexporter
1
0
Fork 0
mirror of https://github.com/playmusicexporter/playmusicexporter synced 2024-05-15 19:46:44 +00:00
Code Issues Releases Wiki Activity

#29: Add missing todos for the error logging

Browse source
This commit is contained in:
Joshua Ott 2017-08-20 13:26:54 +02:00
parent 4941826172
commit aa42259163
3 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
playmusicexporter/src/main/java/re/jcg/playmusicexporter/activities/MusicContainerListActivity.java
View file

@ -218,6 +218,7 @@ public class MusicContainerListActivity extends AppCompatActivity
} catch (Exception e) {
// Failed
// todo: Add logging
}
}

2
playmusiclib/src/main/java/de/arcus/playmusiclib/ArtworkLoader.java
View file

@ -58,6 +58,7 @@ public class ArtworkLoader {
bitmap = ImageTools.decodeByteArraySubsampled(bitmapData, artworkSize, artworkSize);
} catch (Exception e) {
// Error
// todo: Add logging
}
}
@ -73,6 +74,7 @@ public class ArtworkLoader {
}
} catch (Exception e) {
// Error
// todo: Add logging
}
}
}

14
playmusiclib/src/main/java/de/arcus/playmusiclib/PlayMusicManager.java
View file

@ -600,14 +600,16 @@ public class PlayMusicManager {
if (!trackWriteID3(musicTrack, fileTmp, dest)) {
// Failed, moving without meta data
if (!FileTools.fileMove(fileTmp, dest)) {
// Could not copy the file
// Could not copy the file, moving the raw file failed
// todo: Add logging
return false;
}
}
} else {
// Moving the file
if (!FileTools.fileMove(fileTmp, dest)) {
// Could not copy the file
// Could not copy the file, moving the raw file failed
// todo: Add logging
return false;
}
}
@ -635,10 +637,12 @@ public class PlayMusicManager {
parcelFileDescriptor.close();
} catch (FileNotFoundException e) {
// Could not copy the file
// Could not copy the file, file not found
// todo: Add logging
return false;
} catch (IOException e) {
// Could not copy the file
// Could not copy the file, failed to write the documen
// todo: Add logging
return false;
}
}
@ -800,6 +804,8 @@ public class PlayMusicManager {
// Checks the magic number
if (!allAccessExporter.hasValidMagicNumber()) {
// Failed
// todo: Add logging
return false;
}