112 lines
3.5 KiB
Diff
112 lines
3.5 KiB
Diff
From d2cc22580898df5d4a15e0f99ab513e1570a6082 Mon Sep 17 00:00:00 2001
|
|
From: Zoltan Varga <vargaz@gmail.com>
|
|
Date: Fri, 20 Sep 2013 19:06:34 +0200
|
|
Subject: [PATCH] [sgen] Use __builtin_ctzl () in OBJ_BITMAP_FOREACH_PTR () on
|
|
64 bit platforms. Fixes #14834.
|
|
|
|
---
|
|
mono/metadata/sgen-descriptor.h | 28 +++++++++++++++++++++++++---
|
|
mono/tests/sgen-descriptors.cs | 15 +++++++++++++--
|
|
2 files changed, 38 insertions(+), 5 deletions(-)
|
|
|
|
diff --git a/mono/metadata/sgen-descriptor.h b/mono/metadata/sgen-descriptor.h
|
|
index cd53a86..3a00589 100644
|
|
--- a/mono/metadata/sgen-descriptor.h
|
|
+++ b/mono/metadata/sgen-descriptor.h
|
|
@@ -170,21 +170,43 @@ enum {
|
|
} \
|
|
} while (0)
|
|
|
|
-#ifdef __GNUC__
|
|
+#if defined(__GNUC__) && SIZEOF_VOID_P==4
|
|
+#define OBJ_BITMAP_FOREACH_PTR(desc,obj) do { \
|
|
+ /* there are pointers */ \
|
|
+ void **_objptr = (void**)(obj); \
|
|
+ gsize _bmap = (desc) >> 16; \
|
|
+ _objptr += OBJECT_HEADER_WORDS; \
|
|
+ { \
|
|
+ int _index = __builtin_ctz (_bmap); \
|
|
+ _objptr += _index; \
|
|
+ _bmap >>= (_index + 1); \
|
|
+ HANDLE_PTR (_objptr, (obj)); \
|
|
+ _objptr ++; \
|
|
+ } \
|
|
+ while (_bmap) { \
|
|
+ int _index = __builtin_ctz (_bmap); \
|
|
+ _objptr += _index; \
|
|
+ _bmap >>= (_index + 1); \
|
|
+ HANDLE_PTR (_objptr, (obj)); \
|
|
+ _objptr ++; \
|
|
+ } \
|
|
+ } while (0)
|
|
+#elif defined(__GNUC__) && SIZEOF_VOID_P==8
|
|
+/* Same as above, but use _builtin_ctzl () */
|
|
#define OBJ_BITMAP_FOREACH_PTR(desc,obj) do { \
|
|
/* there are pointers */ \
|
|
void **_objptr = (void**)(obj); \
|
|
gsize _bmap = (desc) >> 16; \
|
|
_objptr += OBJECT_HEADER_WORDS; \
|
|
{ \
|
|
- int _index = __builtin_ctz (_bmap); \
|
|
+ int _index = __builtin_ctzl (_bmap); \
|
|
_objptr += _index; \
|
|
_bmap >>= (_index + 1); \
|
|
HANDLE_PTR (_objptr, (obj)); \
|
|
_objptr ++; \
|
|
} \
|
|
while (_bmap) { \
|
|
- int _index = __builtin_ctz (_bmap); \
|
|
+ int _index = __builtin_ctzl (_bmap); \
|
|
_objptr += _index; \
|
|
_bmap >>= (_index + 1); \
|
|
HANDLE_PTR (_objptr, (obj)); \
|
|
diff --git a/mono/tests/sgen-descriptors.cs b/mono/tests/sgen-descriptors.cs
|
|
index ae00084..246e5aa 100644
|
|
--- a/mono/tests/sgen-descriptors.cs
|
|
+++ b/mono/tests/sgen-descriptors.cs
|
|
@@ -1,4 +1,5 @@
|
|
using System;
|
|
+using System.Runtime.InteropServices;
|
|
|
|
public struct SmallMixed
|
|
{
|
|
@@ -47,6 +48,13 @@ public class HugePtrFree {
|
|
public LargeStruct2 c;
|
|
}
|
|
|
|
+[StructLayout (LayoutKind.Sequential)]
|
|
+public class Non32bitBitmap {
|
|
+ public object o;
|
|
+ public long i1, i2, i3, i4, i5, i6, i7, i8, i9, i10, i11, i12, i13, i14, i15, i16, i17, i18, i19, i20, i21, i22, i23, i24, i25, i26, i27, i28, i29, i30, i31, i32, i33, i34, i35;
|
|
+ public object o2;
|
|
+}
|
|
+
|
|
/*
|
|
This is a stress test for descriptors.
|
|
*/
|
|
@@ -54,10 +62,10 @@ class Driver {
|
|
static char[] FOO = new char[] { 'f', 'o', 'b' };
|
|
|
|
static void Fill (int cycles) {
|
|
- object[] root = new object [12];
|
|
+ object[] root = new object [13];
|
|
object[] current = root;
|
|
for (int i = 0; i < cycles; ++i) {
|
|
- current [0] = new object [12];
|
|
+ current [0] = new object [13];
|
|
current [1] = new int [6];
|
|
current [2] = new int [2,3];
|
|
current [3] = new string (FOO);
|
|
@@ -72,6 +80,9 @@ class Driver {
|
|
current [10] = new HugePtrFree ();
|
|
if ((i % 10000) == 0)
|
|
current [11] = new LargeStruct2 [1];
|
|
+
|
|
+ /* Test for 64 bit bitmap descriptors (#14834) */
|
|
+ current [12] = new Non32bitBitmap () { o = new object (), i32 = 1, i33 = 1, i34 = 1, i35 = 1, o2 = new object () };
|
|
|
|
current = (object[])current [0];
|
|
}
|
|
--
|
|
1.8.4
|
|
|