c4426b14b8
Additions by q66: - external cargo bootstrap is always used now - docs are enabled (for non-bindists) + removed noarch
53 lines
2.4 KiB
Diff
53 lines
2.4 KiB
Diff
From baa7ce46f19e3584d70e47c8df28c084e76446da Mon Sep 17 00:00:00 2001
|
|
From: Samuel Holland <samuel@sholland.org>
|
|
Date: Sun, 3 May 2020 17:48:47 +0200
|
|
Subject: [PATCH 03/15] Require static native libraries when linking static
|
|
executables
|
|
|
|
On ELF targets like Linux, gcc/ld will create a dynamically-linked
|
|
executable without warning, even when passed `-static`, when asked to
|
|
link to a `.so`. Avoid this confusing and unintended behavior by always
|
|
using the static version of libraries when trying to link static
|
|
executables.
|
|
|
|
Fixes #54243
|
|
---
|
|
src/librustc_codegen_ssa/back/link.rs | 18 ++++++++++++++----
|
|
1 file changed, 14 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/src/librustc_codegen_ssa/back/link.rs b/src/librustc_codegen_ssa/back/link.rs
|
|
index 0dd2f029..f22b4277 100644
|
|
--- a/compiler/rustc_codegen_ssa/src/back/link.rs
|
|
+++ b/compiler/rustc_codegen_ssa/src/back/link.rs
|
|
@@ -1964,9 +1964,7 @@
|
|
}
|
|
}
|
|
|
|
-// Link in all of our upstream crates' native dependencies. Remember that
|
|
-// all of these upstream native dependencies are all non-static
|
|
-// dependencies. We've got two cases then:
|
|
+// Link in all of our upstream crates' native dependencies. We have two cases:
|
|
//
|
|
// 1. The upstream crate is an rlib. In this case we *must* link in the
|
|
// native dependency because the rlib is just an archive.
|
|
@@ -2015,7 +2013,19 @@
|
|
continue;
|
|
}
|
|
match lib.kind {
|
|
- NativeLibKind::Dylib | NativeLibKind::Unspecified => cmd.link_dylib(name),
|
|
+ NativeLibKind::Dylib | NativeLibKind::Unspecified => {
|
|
+ // On some targets, like Linux, linking a static executable inhibits using
|
|
+ // dylibs at all. Force native libraries to be static, even if for example
|
|
+ // an upstream rlib was originally linked against a native shared library.
|
|
+ if crate_type == config::CrateType::Executable
|
|
+ && sess.crt_static(Some(crate_type))
|
|
+ && !sess.target.target.options.crt_static_allows_dylibs
|
|
+ {
|
|
+ cmd.link_staticlib(name)
|
|
+ } else {
|
|
+ cmd.link_dylib(name)
|
|
+ }
|
|
+ },
|
|
NativeLibKind::Framework => cmd.link_framework(name),
|
|
NativeLibKind::StaticNoBundle => {
|
|
// Link "static-nobundle" native libs only if the crate they originate from
|