602d5b2383
disable-crash-reporter.patch: - removed defunct part (which would yield false for a < b === undefined)
58 lines
2.3 KiB
Diff
58 lines
2.3 KiB
Diff
From afa206dc466066c3d273dfc879103700505b3d7b Mon Sep 17 00:00:00 2001
|
|
From: Joshua Strobl <joshua@streambits.io>
|
|
Date: Sun, 22 Aug 2021 14:02:05 +0300
|
|
Subject: [PATCH 1/1] Disable crash reporter since Microsoft refuses to fix
|
|
this upstream.
|
|
|
|
Unfortunately a PR submitted by a third-party was rejected by Microsoft, which would change the default for crash reporting from true to false and move the telemetry configuration to ensure crash reporting was not being forced on, placed in the argv.json, and cause a crash when improperly set.
|
|
|
|
So, disable it entirely. No cookies for you, Visual Studio Code team.
|
|
---
|
|
src/bootstrap-fork.js | 3 ---
|
|
src/main.js | 16 ----------------
|
|
src/vs/code/electron-main/app.ts | 2 +-
|
|
3 files changed, 1 insertion(+), 20 deletions(-)
|
|
|
|
diff --git a/src/bootstrap-fork.js b/src/bootstrap-fork.js
|
|
index f7b07e49255..576c82f23e8 100644
|
|
--- a/src/bootstrap-fork.js
|
|
+++ b/src/bootstrap-fork.js
|
|
@@ -37,9 +37,6 @@ if (process.env['VSCODE_PARENT_PID']) {
|
|
terminateWhenParentTerminates();
|
|
}
|
|
|
|
-// Configure Crash Reporter
|
|
-configureCrashReporter();
|
|
-
|
|
// Load AMD entry point
|
|
require('./bootstrap-amd').load(process.env['VSCODE_AMD_ENTRYPOINT']);
|
|
|
|
diff --git a/src/main.js b/src/main.js
|
|
index ad838aa245e..e6319e100b9 100644
|
|
--- a/src/main.js
|
|
+++ b/src/main.js
|
|
@@ -46,22 +46,6 @@ const codeCachePath = getCodeCachePath();
|
|
// Configure static command line arguments
|
|
const argvConfig = configureCommandlineSwitchesSync(args);
|
|
|
|
-// Configure crash reporter
|
|
-perf.mark('code/willStartCrashReporter');
|
|
-// If a crash-reporter-directory is specified we store the crash reports
|
|
-// in the specified directory and don't upload them to the crash server.
|
|
-//
|
|
-// Appcenter crash reporting is enabled if
|
|
-// * enable-crash-reporter runtime argument is set to 'true'
|
|
-// * --disable-crash-reporter command line parameter is not set
|
|
-//
|
|
-// Disable crash reporting in all other cases.
|
|
-if (args['crash-reporter-directory'] ||
|
|
- (argvConfig['enable-crash-reporter'] && !args['disable-crash-reporter'])) {
|
|
- configureCrashReporter();
|
|
-}
|
|
-perf.mark('code/didStartCrashReporter');
|
|
-
|
|
// Set logs path before app 'ready' event if running portable
|
|
// to ensure that no 'logs' folder is created on disk at a
|
|
// location outside of the portable directory
|
|
--
|
|
2.32.0
|