jcgruenhage/void-packages
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

common/build-style: remove go_get from Go style.

Browse source 
Fix Manual accordingly, and also fix indentation to be compatible with
nearby items.

The two packages which set this variable set it explicitly to "no", so
it wasn't relied upon. From its description, it was recommended only for
git packages, which by default don't fit Void's packaging guidelines.
Removing to avoid anyone coming to rely on it.
This commit is contained in:
Érico Rolim 2021-02-19 17:24:28 -03:00 committed by Érico Nogueira Rolim
parent f529f48791
commit d9c83dbe8b
4 changed files with 6 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Manual.md
View file

@ -914,12 +914,11 @@ that do such things as append (`+=`) to variables, should have `make_use_env`
set in the body of the template. set in the body of the template.
- `go` For programs written in Go that follow the standard package - `go` For programs written in Go that follow the standard package
structure. The variable `go_import_path` must be set to the package's structure. The variable `go_import_path` must be set to the package's
import path, e.g. `github.com/github/hub` for the `hub` program. If import path, e.g. `github.com/github/hub` for the `hub` program. This
the variable `go_get` is set to `yes`, the package will be information can be found in the `go.mod` file for modern Go projects.
downloaded with `go get`. Otherwise (the default) it's expected that It's expected that the distfile contains the package, but dependencies
the distfile contains the package. In both cases, dependencies will will be downloaded with `go get`.
be downloaded with `go get`.
- `meta` For `meta-packages`, i.e packages that only install local files or simply - `meta` For `meta-packages`, i.e packages that only install local files or simply
depend on additional packages. This build style does not install depend on additional packages. This build style does not install
@ -1585,10 +1584,6 @@ The following template variables influence how Go packages are built:
variable is required. variable is required.
- `go_package`: A space-separated list of import paths of the packages - `go_package`: A space-separated list of import paths of the packages
that should be built. Defaults to `go_import_path`. that should be built. Defaults to `go_import_path`.
- `go_get`: If set to yes, the package specified via `go_import_path`
will be downloaded with `go get`. Otherwise, a distfile has to be
provided. This option should only be used with `-git` (or similar)
packages; using a versioned distfile is preferred.
- `go_build_tags`: An optional, space-separated list of build tags to - `go_build_tags`: An optional, space-separated list of build tags to
pass to Go. pass to Go.
- `go_mod_mode`: The module download mode to use. May be `off` to ignore - `go_mod_mode`: The module download mode to use. May be `off` to ignore

2
common/build-style/go.sh
View file

@ -15,7 +15,7 @@ do_configure() {
if [ "${go_mod_mode}" != "off" ] && [ -f go.mod ]; then if [ "${go_mod_mode}" != "off" ] && [ -f go.mod ]; then
# Skip GOPATH symlink for Go modules # Skip GOPATH symlink for Go modules
msg_normal "Building $pkgname using Go modules.\n" msg_normal "Building $pkgname using Go modules.\n"
elif [ "${go_get}" != "yes" ]; then else
mkdir -p ${GOSRCPATH%/*}/ mkdir -p ${GOSRCPATH%/*}/
ln -fs "$PWD" "${GOSRCPATH}" ln -fs "$PWD" "${GOSRCPATH}"
fi fi

1
srcpkgs/doctl/template
View file

@ -5,7 +5,6 @@ revision=1
build_style=go build_style=go
go_import_path="github.com/digitalocean/doctl/cmd/doctl" go_import_path="github.com/digitalocean/doctl/cmd/doctl"
go_build_tags="v${version}" go_build_tags="v${version}"
go_get="no"
short_desc="Command line tool for DigitalOcean services" short_desc="Command line tool for DigitalOcean services"
maintainer="Benjamín Albiñana <benalb@gmail.com>" maintainer="Benjamín Albiñana <benalb@gmail.com>"
license="Apache-2.0" license="Apache-2.0"

1
srcpkgs/goimapnotify/template
View file

@ -4,7 +4,6 @@ version=2.0
revision=1 revision=1
build_style=go build_style=go
go_import_path="gitlab.com/shackra/goimapnotify" go_import_path="gitlab.com/shackra/goimapnotify"
go_get="no"
hostmakedepends="git" hostmakedepends="git"
short_desc="Execute scripts on IMAP idle notifications (Go version)" short_desc="Execute scripts on IMAP idle notifications (Go version)"
maintainer="Andrew J. Hesford <ajh@sideband.org>" maintainer="Andrew J. Hesford <ajh@sideband.org>"