jcgruenhage/void-packages
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

.github: improve the PR template

Browse source 
* switch from using checkboxes to **YES**|**NO** options
* make it clear that filling out the part about manual builds is only
  necessary when the CI is skipped, this was easy to miss
This commit is contained in:
Michal Vasilek 2021-09-25 14:56:06 +02:00 committed by Piraty
parent 67cfa52b31
commit 980cf96a29
1 changed files with 16 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
.github/pull_request_template.md vendored
View file

@ -1,26 +1,22 @@
<!-- Mark items with [x] where applicable --> <!-- Uncomment relevant sections and delete options which are not applicable -->
#### General #### Testing the changes
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) - I tested the changes in this PR: **YES**|**briefly**|**NO**
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!-- <!--
If GitHub CI cannot be used to validate the build result (for example, if the #### New package
build is likely to take several hours), make sure to - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). -->
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
acceptable to skip CI. and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
--> -->
<!-- <!--
#### Does it build and run successfully? #### Local build testing
(Please choose at least one native build and, if supported, at least one cross build. More are better.) - I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl
- [ ] aarch64-musl - armv7l
- [ ] armv7l - armv6l-musl
- [ ] armv6l-musl
--> -->