Fix ping intervals #3
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Right now, we have a
Stream
of pings, which we can handle withfor_each
, orfor_each_concurrent
. Withfor_each
, the next ping will only start after the first ping has been handled completely, where asfor_each_concurrent
will just bash out the pings at max speed. Neither is satisfactory, since we'd want a configurable, static stream of pings, for example every 100ms or something like that.For documentation purposes: Currently, we use for_each, with an additional delay between old ping being finished and new ping being fired. The delay is the interval configured in the config file.
This was actually easier than I thought, so I fixed it.
Here is the log from before the fix:
Here is the log from after the fix:
As you can see, this is now way more constant. Pushing the fix soon.
So. the ping intervals haven't been fixed for anything where the pings took longer than the interval, so no concurrent pings.
This is for pinging 122.49.191.252 every 100ms and 1.0.0.1 and 1.1.1.1 every 500ms. Clearly, 122.49.191.252 is not pinged 5 times as often.
Fixed in
44251fa2f7
: