Merge dd3b6b9b28 into 9d3aa8416b

.github/workflows/lint.yaml

@@ -0,0 +1,20 @@
+---
+name: Lint
+on:
+  push:
+    branches:
+    - main
+  pull_request:
+    branches:
+    - main
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - run: pipx install hatch
+      - run: hatch -e ci run ruff check paperless_asn_qr_codes
+        # temporary allow failures on pylint until we've fixed all issues
+      - run: hatch -e ci run pylint paperless_asn_qr_codes || exit 0
+      - run: hatch -e ci run black paperless_asn_qr_codes --check --diff

paperless_asn_qr_codes/avery_labels.py

@@ -1,11 +1,7 @@
-import os
 from dataclasses import dataclass, KW_ONLY
 from collections.abc import Iterator
 from reportlab.pdfgen import canvas
 from reportlab.lib.pagesizes import LETTER, A4
-from reportlab.lib.units import inch
-from reportlab.pdfbase import pdfmetrics
-from reportlab.pdfbase.ttfonts import TTFont
 from reportlab.lib.units import mm
 
 # Usage:
@@ -116,9 +112,9 @@ class AveryLabel:
         self.canvas.setLineCap(1)
 
     def topLeft(self, x=None, y=None):
-        if x == None:
+        if x is None:
             x = self.position
-        if y == None:
+        if y is None:
             if self.topDown:
                 x, y = divmod(x, self.down)
             else:

paperless_asn_qr_codes/main.py

@@ -1,6 +1,6 @@
 import argparse
 
-from reportlab.lib.units import mm, cm
+from reportlab.lib.units import mm
 from reportlab_qrcode import QRCodeImage
 from paperless_asn_qr_codes import avery_labels
 
@@ -27,7 +27,9 @@ def main():
         "--format", choices=avery_labels.labelInfo.keys(), default="averyL4731"
     )
     parser.add_argument(
-        "--border", action='store_true', help="Display borders around labels, useful for debugging the printer alignment"
+        "--border",
+        action="store_true",
+        help="Display borders around labels, useful for debugging the printer alignment",
     )
     args = parser.parse_args()
     global startASN

pyproject.toml

@@ -28,6 +28,13 @@ dependencies = [
 ]
 dynamic = ["version"]
 
+[project.optional-dependencies]
+dev = [
+  "pylint",
+  "ruff",
+  "black",
+]
+
 [project.urls]
 Documentation = "https://github.com/entropia/paperless-asn-qr-codes#readme"
 Issues = "https://github.com/entropia/paperless-asn-qr-codes/issues"
@@ -38,3 +45,8 @@ paperless-asn-qr-codes = "paperless_asn_qr_codes.main:main"
 
 [tool.hatch.version]
 source = "vcs"
+
+[tool.hatch.envs.ci]
+features = [
+  "dev"
+]