Add review for slug v0.1.4
This commit is contained in:
parent
876efa6353
commit
e2bc88911e
1 changed files with 34 additions and 0 deletions
|
@ -0,0 +1,34 @@
|
||||||
|
----- BEGIN CREV PROOF -----
|
||||||
|
kind: package review
|
||||||
|
version: -1
|
||||||
|
date: "2021-02-15T21:29:13.505132766+01:00"
|
||||||
|
from:
|
||||||
|
id-type: crev
|
||||||
|
id: YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM
|
||||||
|
url: "https://git.jcg.re/jcgruenhage/crev-proofs.git"
|
||||||
|
package:
|
||||||
|
source: "https://crates.io"
|
||||||
|
name: slug
|
||||||
|
version: 0.1.4
|
||||||
|
revision: 1436a3b1f9362cb413bcee9ff86ef20840ed0916
|
||||||
|
digest: Q4CWSCF1ik0ZXxI7AWtVj-SFN1gwJPpheP1PRThK_xA
|
||||||
|
review:
|
||||||
|
thoroughness: high
|
||||||
|
understanding: high
|
||||||
|
rating: positive
|
||||||
|
alternatives:
|
||||||
|
- source: "https://crates.io"
|
||||||
|
name: str_slug
|
||||||
|
comment: |-
|
||||||
|
Short and concise implementation. A little code that's technically unsafe, for
|
||||||
|
lowercasing ASCII, as Rust's `to_lowercase()` impl is slower because it's
|
||||||
|
unicode aware. As it doesn't have to handle unicode where it's used, it is
|
||||||
|
still sound.
|
||||||
|
|
||||||
|
Aside of it's own code, there is unsafe in the deps too: If `deunicode` is
|
||||||
|
fine, then this is too. I didn't invest enough time in `deunicode` to make a
|
||||||
|
final judgement about it, but others have so it's probably okay.
|
||||||
|
----- SIGN CREV PROOF -----
|
||||||
|
5eqM8gp_WBP44B3azUOT7_yDeJHEnKamgNHQenmiC51OWcjm0OW5wl5u7mlABoDg1qzNTawjCIyiJ5abdM_lCA
|
||||||
|
----- END CREV PROOF -----
|
||||||
|
|
Loading…
Reference in a new issue