jcgruenhage/crev-proofs
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Add review for yap v0.8.0

Browse source
This commit is contained in:
Jan Christian Grünhage 2022-07-07 07:37:15 +02:00
parent ee6ef0f296
commit b8bf57a8a1
1 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM/reviews/2022-07-package-0Oh57g.proof.crev Normal file
View file

@ -0,0 +1,29 @@
----- BEGIN CREV PROOF -----
kind: package review
version: -1
date: "2022-07-07T07:37:15.986010721+02:00"
from:
id-type: crev
id: YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM
url: "https://git.jcg.re/jcgruenhage/crev-proofs.git"
package:
source: "https://crates.io"
name: yap
version: 0.8.0
revision: 1918ec523cdca956b83e34aaa0de65d54ba6b962
digest: o662jTvJbUJREUMUPUTeqNWJzKWwIXOOPClPZOHdQ5U
review:
thoroughness: high
understanding: high
rating: positive
alternatives:
- source: "https://crates.io"
name: nom
comment: |-
Follow-up from my previous review for version 0.7.2: The sound use of unsafe has now gotten a test case to show that it's actually working as expected with exotic characters, and the `Tokens::optional_err` function I was missing last time is something I've contributed since. Still very happy with yap, and looking forward to seeing this used more.
For a more detailed review, read my previous coverage of 0.7.2.
----- SIGN CREV PROOF -----
o5nfh-fDuC01CACyF4xKcgaJc8zPw_xCz2oRADWBz3VH9vPqS73vIuFc21tESo1Ca9Cvl468D62HLvhyv-TvBg
----- END CREV PROOF -----