Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed improvements #51

Open
3 tasks
J05HI opened this issue Aug 17, 2017 · 4 comments
Open
3 tasks

Speed improvements #51

J05HI opened this issue Aug 17, 2017 · 4 comments

Comments

@J05HI
Copy link

J05HI commented Aug 17, 2017

Some stuff could be improved:

  • Currently each cover and music track is loaded separately with a superuser command which is really slow.
    We should copy all covers and encrypted mp3s to a normal accessible location (if they aren't already)
    • Cover loading
    • Music loading
@jcgruenhage
Copy link
Collaborator

We should copy all covers and encrypted mp3s

Wow, NO. When would you do that? During app startup? That would take forever, ignoring the fact, that this will use a shitload of additional space. Maybe covers, no way we'll copy mp3s though.

@J05HI
Copy link
Author

J05HI commented Aug 17, 2017

@jcgruenhage

No, sorry for the bad description of the issue. I won't copy the mp3s. Only the covers (this takes a part of a second) and doesn't take that much space.

We only need to copy them if they aren't on the SD card, if they are already (in "SDCARD/Android/data...") we can access them with a normal file access.

Loading the covers on scroll will nearly instantly then.

@jcgruenhage
Copy link
Collaborator

That seems more reasonable, thanks for the better description. Should we maybe have thumbnails for most covers in memory already? Not large ones, just 128² or something like that.

@J05HI
Copy link
Author

J05HI commented Aug 17, 2017

@jcgruenhage

Maby if it doesn't take too much memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants