Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded music only setting #44

Open
J05HI opened this issue Aug 12, 2017 · 8 comments
Open

Downloaded music only setting #44

J05HI opened this issue Aug 12, 2017 · 8 comments

Comments

@J05HI
Copy link

J05HI commented Aug 12, 2017

There should be 3 options:
• All music
• Downloaded & cached music
• Downloaded music only

@jcgruenhage
Copy link
Collaborator

Actually, it's even more, it shows all music in the local play music db. Showing only available for export songs (cached & downloaded) or even only downloaded songs might make sense though.

@J05HI
Copy link
Author

J05HI commented Aug 12, 2017

@jcgruenhage
Yeah there should be 3 options:

  • All music
  • Downloaded & cached music
  • Downloaded music only

I'll take a look at this if I have time

@jcgruenhage
Copy link
Collaborator

Steps needed for that:

  1. Take a look at the db, to figure out where that info is at (hopefully all that is in the db somewhere).
  2. Implement logic it in playmusiclib.
  3. Implement setting (and the filtering in the music listing activities) in playmusicexporter.

Maybe we should do #29 first though.

@J05HI
Copy link
Author

J05HI commented Aug 12, 2017

Okay then I'll look at the cleanup first

@jcgruenhage
Copy link
Collaborator

Especially moving the playmusiclib to it's own repo.. Maybe we should just do an Org, move this repo over there, create the playmusiclib repo and I could just give you commit access to both.

It'll probably take a while though, I'll go on vacation tomorrow.

@J05HI
Copy link
Author

J05HI commented Aug 12, 2017

@jcgruenhage
Okay would be great!

@jcgruenhage
Copy link
Collaborator

I've prepared it so far, org is created, this repo was moved, the new playmusicexporter/playmusiclib repo was created, and I've invited you (and @mgillespie) into that org, and given all members write access to all repos.

@J05HI
Copy link
Author

J05HI commented Aug 12, 2017

@jcgruenhage
Great thank you!
And now have a nice holiday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants