From 9c6e32a537a833afd2ee42f84ab70fca5a9b7815 Mon Sep 17 00:00:00 2001 From: Mark Gillespie Date: Fri, 10 Mar 2017 10:16:41 +0000 Subject: [PATCH 1/2] Device Info and SDK in crash handler. --- .../java/de/arcus/framework/crashhandler/CrashHandler.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java b/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java index d4be390..87eca8a 100644 --- a/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java +++ b/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java @@ -24,6 +24,7 @@ package de.arcus.framework.crashhandler; import android.app.Activity; import android.content.Intent; +import android.os.Build; import de.arcus.framework.activities.CrashActivity; import de.arcus.framework.logger.Logger; @@ -70,6 +71,12 @@ public class CrashHandler implements Thread.UncaughtExceptionHandler { StringBuilder logBuilder = new StringBuilder(); + //Device Information + logBuilder.append("---------- Device Information -----------\n"); + logBuilder.append("Manufacturer: ").append(Build.MANUFACTURER).append("\n"); + logBuilder.append("Model: ").append(Build.MODEL).append("\n"); + logBuilder.append("Device API: ").append(Build.VERSION.RELEASE).append("\n"); + // Information logBuilder.append("---------- Information -----------\n"); logBuilder.append("PackageName: ").append(mActivity.getPackageName()).append("\n"); From 6ecfb0539153db57764d3fc8e6a49f22ba6bf2d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?yJan=20Christian=20Gr=C3=BCnhage?= Date: Fri, 10 Mar 2017 11:51:40 +0100 Subject: [PATCH 2/2] Added some more info and a debug setting to test the crash handler. --- .../arcus/framework/crashhandler/CrashHandler.java | 7 +++++++ .../activities/SettingsActivity.java | 13 ++++++------- .../src/main/res/values-de/strings.xml | 1 + playmusicexporter/src/main/res/values/strings.xml | 1 + playmusicexporter/src/main/res/xml/pref_debug.xml | 2 ++ 5 files changed, 17 insertions(+), 7 deletions(-) diff --git a/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java b/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java index 87eca8a..6508ca7 100644 --- a/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java +++ b/framework/src/main/java/de/arcus/framework/crashhandler/CrashHandler.java @@ -76,11 +76,18 @@ public class CrashHandler implements Thread.UncaughtExceptionHandler { logBuilder.append("Manufacturer: ").append(Build.MANUFACTURER).append("\n"); logBuilder.append("Model: ").append(Build.MODEL).append("\n"); logBuilder.append("Device API: ").append(Build.VERSION.RELEASE).append("\n"); + logBuilder.append("Product: ").append(Build.PRODUCT).append("\n"); + logBuilder.append("Build Number: ").append(Build.DISPLAY).append("\n"); + logBuilder.append("Build Tags: ").append(Build.TAGS).append("\n"); + logBuilder.append("\n"); + // Information logBuilder.append("---------- Information -----------\n"); logBuilder.append("PackageName: ").append(mActivity.getPackageName()).append("\n"); logBuilder.append("Crashed activity: ").append(mActivity.getLocalClassName()).append("\n"); + logBuilder.append("\n"); + logBuilder.append("----------- Exception ------------\n"); logBuilder.append(ex.getMessage()).append("\n"); diff --git a/playmusicexporter/src/main/java/re/jcg/playmusicexporter/activities/SettingsActivity.java b/playmusicexporter/src/main/java/re/jcg/playmusicexporter/activities/SettingsActivity.java index faa4ca2..c58c676 100644 --- a/playmusicexporter/src/main/java/re/jcg/playmusicexporter/activities/SettingsActivity.java +++ b/playmusicexporter/src/main/java/re/jcg/playmusicexporter/activities/SettingsActivity.java @@ -325,13 +325,12 @@ public class SettingsActivity extends AppCompatPreferenceActivity { addPreferencesFromResource(R.xml.pref_debug); setHasOptionsMenu(true); - findPreference("debug_trigger_export_all").setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() { - @Override - public boolean onPreferenceClick(Preference preference) { - Log.i(TAG, "Debug Trigger Export All Click registered."); - ExportAllService.startExport(getActivity()); - return true; - } + findPreference("debug_trigger_export_all").setOnPreferenceClickListener(preference -> { + ExportAllService.startExport(getActivity()); + return true; + }); + findPreference("debug_test_crash_handler").setOnPreferenceClickListener(preference -> { + throw new IllegalStateException("Test for the crash handler."); }); } diff --git a/playmusicexporter/src/main/res/values-de/strings.xml b/playmusicexporter/src/main/res/values-de/strings.xml index 14498df..5feb8ac 100644 --- a/playmusicexporter/src/main/res/values-de/strings.xml +++ b/playmusicexporter/src/main/res/values-de/strings.xml @@ -108,4 +108,5 @@ Bestehende Dateien überschreiben Datenbank neu laden Datenbank neu geladen + Teste Fehlerbehandlung \ No newline at end of file diff --git a/playmusicexporter/src/main/res/values/strings.xml b/playmusicexporter/src/main/res/values/strings.xml index 66aa76e..7b8763c 100644 --- a/playmusicexporter/src/main/res/values/strings.xml +++ b/playmusicexporter/src/main/res/values/strings.xml @@ -148,4 +148,5 @@ Overwrite Existing Files Refresh Music Database Reloaded + Test Crash Handler diff --git a/playmusicexporter/src/main/res/xml/pref_debug.xml b/playmusicexporter/src/main/res/xml/pref_debug.xml index ea57311..d147b4a 100644 --- a/playmusicexporter/src/main/res/xml/pref_debug.xml +++ b/playmusicexporter/src/main/res/xml/pref_debug.xml @@ -2,5 +2,7 @@ +