From 4941826172f59145c197b984ffba659e882dac12 Mon Sep 17 00:00:00 2001 From: Joshua Ott Date: Thu, 17 Aug 2017 19:44:17 +0200 Subject: [PATCH] #29: Add todos for the error logging --- .../main/java/de/arcus/playmusiclib/PlayMusicManager.java | 2 ++ .../java/de/arcus/playmusiclib/items/MusicTrackList.java | 1 + .../src/main/java/de/arcus/playmusiclib/utils/FileTools.java | 5 +++++ 3 files changed, 8 insertions(+) diff --git a/playmusiclib/src/main/java/de/arcus/playmusiclib/PlayMusicManager.java b/playmusiclib/src/main/java/de/arcus/playmusiclib/PlayMusicManager.java index d8bfefe..12e985c 100644 --- a/playmusiclib/src/main/java/de/arcus/playmusiclib/PlayMusicManager.java +++ b/playmusiclib/src/main/java/de/arcus/playmusiclib/PlayMusicManager.java @@ -752,6 +752,7 @@ public class PlayMusicManager { tagID3v2.setGenreDescription(musicTrack.getGenre()); } catch (IllegalArgumentException e) { // Failed + // todo: Add logging } } @@ -806,6 +807,7 @@ public class PlayMusicManager { return allAccessExporter.save(dest); } catch (Exception e) { // Failed + // todo: Add logging } // Failed diff --git a/playmusiclib/src/main/java/de/arcus/playmusiclib/items/MusicTrackList.java b/playmusiclib/src/main/java/de/arcus/playmusiclib/items/MusicTrackList.java index a7e2528..6adcfc6 100644 --- a/playmusiclib/src/main/java/de/arcus/playmusiclib/items/MusicTrackList.java +++ b/playmusiclib/src/main/java/de/arcus/playmusiclib/items/MusicTrackList.java @@ -125,6 +125,7 @@ public abstract class MusicTrackList extends ArtworkEntry { } // Failed + // todo: Add logging return null; } diff --git a/playmusiclib/src/main/java/de/arcus/playmusiclib/utils/FileTools.java b/playmusiclib/src/main/java/de/arcus/playmusiclib/utils/FileTools.java index 5e86edc..9eebccc 100644 --- a/playmusiclib/src/main/java/de/arcus/playmusiclib/utils/FileTools.java +++ b/playmusiclib/src/main/java/de/arcus/playmusiclib/utils/FileTools.java @@ -64,6 +64,7 @@ public class FileTools { } } catch (Exception e) { // Failed + // todo: Add logging } return false; } @@ -139,6 +140,7 @@ public class FileTools { success = true; } catch (IOException ex) { // Failed + // todo: Add logging success = false; } @@ -167,6 +169,7 @@ public class FileTools { success = fileCopy(inputStream, outputStream); } catch (IOException ex) { // Failed + // todo: Add logging success = false; } @@ -178,6 +181,7 @@ public class FileTools { outputStream.close(); } catch (IOException ex) { // Failed + // todo: Add logging success = false; } @@ -257,6 +261,7 @@ public class FileTools { } } catch (IOException e) { // Failed + // todo: Add logging e.printStackTrace(); }