40 lines
1.7 KiB
Diff
40 lines
1.7 KiB
Diff
From patchwork Mon Oct 3 20:06:10 2016
|
|
Content-Type: text/plain; charset="utf-8"
|
|
MIME-Version: 1.0
|
|
Content-Transfer-Encoding: 8bit
|
|
Subject: [v4,3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors
|
|
From: =?utf-8?q?Noralf_Tr=C3=B8nnes?= <noralf@tronnes.org>
|
|
X-Patchwork-Id: 9360899
|
|
Message-Id: <1475525174-28604-4-git-send-email-noralf@tronnes.org>
|
|
To: wsa@the-dreams.de, swarren@wwwdotorg.org, eric@anholt.net
|
|
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
|
|
linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org,
|
|
=?UTF-8?q?Noralf=20Tr=C3=B8nnes?= <noralf@tronnes.org>
|
|
Date: Mon, 3 Oct 2016 22:06:10 +0200
|
|
|
|
Writing to an AT24C32 generates on average 2x i2c transfer errors per
|
|
32-byte page write. Which amounts to a lot for a 4k write. This is due
|
|
to the fact that the chip doesn't respond during it's internal write
|
|
cycle when the at24 driver tries and retries the next write.
|
|
Only a handful drivers use dev_err() on transfer error, so switch to
|
|
dev_dbg() instead.
|
|
|
|
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
|
|
Reviewed-by: Eric Anholt <eric@anholt.net>
|
|
---
|
|
drivers/i2c/busses/i2c-bcm2835.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
|
|
index d2ba1a4..54d510a 100644
|
|
--- a/drivers/i2c/busses/i2c-bcm2835.c
|
|
+++ b/drivers/i2c/busses/i2c-bcm2835.c
|
|
@@ -216,7 +216,7 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
|
|
(msg->flags & I2C_M_IGNORE_NAK))
|
|
return 0;
|
|
|
|
- dev_err(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);
|
|
+ dev_dbg(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);
|
|
|
|
if (i2c_dev->msg_err & BCM2835_I2C_S_ERR)
|
|
return -EREMOTEIO;
|