From 05a7a4fabb439d4943cde314085fbcbdab71b243 Mon Sep 17 00:00:00 2001
From: Juan RP <xtraeme@gmail.com>
Date: Sat, 22 Oct 2011 07:11:49 +0200
Subject: [PATCH] xbps-src: error out ASAP if writing metadata fails for any
 reason.

---
 xbps-src/shutils/metadata.sh | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/xbps-src/shutils/metadata.sh b/xbps-src/shutils/metadata.sh
index a68df2d4cc..32d114c1d4 100644
--- a/xbps-src/shutils/metadata.sh
+++ b/xbps-src/shutils/metadata.sh
@@ -402,19 +402,22 @@ _EOF
 	mv -f $TMPFPLIST ${DESTDIR}/files.plist
 	mv -f $TMPFPROPS ${DESTDIR}/props.plist
 
-	{								\
-	$XBPS_PKGDB_CMD sanitize-plist ${DESTDIR}/files.plist;		\
-	$XBPS_PKGDB_CMD sanitize-plist ${DESTDIR}/props.plist;		\
-	chmod 644 ${DESTDIR}/files.plist ${DESTDIR}/props.plist;	\
-	[ -f $metadir/flist ] && chmod 644 $metadir/flist;		\
-									\
+	$XBPS_PKGDB_CMD sanitize-plist ${DESTDIR}/files.plist || \
+		msg_error "$pkgname: failed to externalize files.plist!\n"
+	$XBPS_PKGDB_CMD sanitize-plist ${DESTDIR}/props.plist || \
+		msg_error "$pkgname: failed to externalize props.plist!\n"
+
+	chmod 644 ${DESTDIR}/files.plist ${DESTDIR}/props.plist
+	[ -f $metadir/flist ] && chmod 644 $metadir/flist
+
 	#
 	# Create the INSTALL/REMOVE scripts if package uses them
 	# or uses any available trigger.
 	#
-	xbps_write_metadata_scripts_pkg install;			\
-	xbps_write_metadata_scripts_pkg remove;				\
-	} || return $?
+	xbps_write_metadata_scripts_pkg install || \
+		msg_error "$pkgname: failed to write INSTALL metadata file!\n"
+	xbps_write_metadata_scripts_pkg remove || \
+		msg_error "$pkgname: failed to write REMOVE metadata file!\n"
 
 	msg_normal "$pkgver: successfully created package metadata.\n"
 }