diff --git a/YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM/reviews/2022-09-package-0Oh57g.proof.crev b/YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM/reviews/2022-09-package-0Oh57g.proof.crev index 11eb41b..4c010d6 100644 --- a/YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM/reviews/2022-09-package-0Oh57g.proof.crev +++ b/YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM/reviews/2022-09-package-0Oh57g.proof.crev @@ -71,3 +71,39 @@ comment: |- mY2ODgsozEL4os5aFk0hxL8jH5SHu7awErNdlLHY9UhDL-vLdbDjEIYiD0wFPaTTglTxirK41Jwtokpm4rWyDg ----- END CREV PROOF ----- +----- BEGIN CREV PROOF ----- +kind: package review +version: -1 +date: 2022-09-19T17:10:17.861223964+02:00 +from: + id-type: crev + id: YdnEoYtqvbBGv0hhENLDUYmc3tNfm5V5NIG5hCovHyM + url: https://git.jcg.re/jcgruenhage/crev-proofs.git +package: + source: https://crates.io + name: is-terminal + version: 0.3.0 + revision: 275136008c33722a43724be5a9711af94afa8476 + digest: VtFAGa-8B5YOh1SOZHNPgb9KCSb2fcmOUOhnzRqyHKI +review: + thoroughness: high + understanding: high + rating: positive +comment: |- + Following up my review of atty, this is the alternative that I'm recommending. + The crate is well-maintained and has the soundness problem from atty fixed. + The dependencies have been changed around a bit, with rustix replacing libc, + and windows-sys replacing win-api. This means that there's a bit less unsafe + code in the library here as well. + + The API surface changed a bit as well, but I'd claim that the new API is more + sensible and allows usage on any file descriptor instead of just + stdin/stdout/stderr. + + Finally, this has one additional dependency, `io-lifetimes`, by the same + author. I have not reviewed the implementation, but it's been merged into Rust + itself and stabilized with 1.63, so I am not worrying about it too much. +----- SIGN CREV PROOF ----- +qermifHP4gqqELsV3vdWnIq0b42d0bAPKqVdQQXzc8n2DTpgIZYBnEfjuDFM88O7sWbpAFqHeJ9v2Z2NUnf7BQ +----- END CREV PROOF ----- +